Update angular examples to v21 #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I forgot to remove 
|
pBouillon
changed the title
Contributor
Author
|
Hey @lucaslarroche! While the PR was still open Angular v21 was released, and I thought we would better off doing the update right now instead of suggesting another PR with minimal changes. I've updated 
|
Contributor
Author
|
Hey @lucaslarroche! Just checking in to see if there’s any update or feedback on this PR. Thanks for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular released a few versions since #17 (from v17 to v20) and it brought a lot of updates (signals, coding style, ...)
This PR aims to update the examples to keep them up to date for the two existing examples:
v2-angular-classless-loginandv2-angular-color-schemes-and-modal.Both examples build and run successfully:
I also updated Pico to v2.1.1.
Please let me know if I need to change anything else, and once again: thanks for the awesome work with this!